LackeyCCG

LackeyCCG Forum => Plugins & Plugin Creation Forum => Topic started by: dragostea on June 01, 2015, 03:41:24 PM

Title: Magic Plugin Update
Post by: dragostea on June 01, 2015, 03:41:24 PM
Hi,

Are there plans to update and include the new modern masters 2015 set?

Thanks
Title: Re: Magic Plugin Update
Post by: Bort on June 01, 2015, 06:14:21 PM
If someone could help with the card data file id love to add mm2015. I havent been able to find it.
Title: Re: Magic Plugin Update
Post by: AuraDragon on June 02, 2015, 12:58:41 AM
It's on Gatherer.
Title: Re: Magic Plugin Update
Post by: dragostea on June 02, 2015, 11:27:37 AM
How do I help, Bort? PM me
Title: Re: Magic Plugin Update
Post by: AuraDragon on June 02, 2015, 04:39:49 PM
Filling in a card data file requires someone to do either:

Manual Labour - generally accepted as a form of lite suicide.
or
Automatic Processing - what I generally do.

The latter requires a Program to obtain and format the card data, as well as a Source of data.  There are both already.  Gatherer (http://tinyurl.com/q8rsnug) contains the data for mm2015 on their website and Gatherer Extractor (http://www.mtgsalvation.com/forums/magic-fundamentals/digital-magic-and-mtg-software/337224-mtg-gatherer-extractor-v3-18-database-pics) is the program that can obtain the data from Gatherer.  You'll also need to format the data, probably with Microsoft Excel and some know-how.

Also we can't forget the card images, they can be obtained from Magiccards.info (http://magiccards.info/mm2/en.html) - which also happens to be the usual place Bort gets his images.
Title: Re: Magic Plugin Update
Post by: Burst on June 13, 2015, 02:46:23 PM
I wasn't sure what the abbreviation was, so I used mm15.  A simple search and replace should be sufficient to fix it if that's not what is needed

https://dl.dropboxusercontent.com/u/75336811/mm15.txt

I hope that helps
Title: Re: Magic Plugin Update
Post by: AuraDragon on June 13, 2015, 09:40:08 PM
Looks good.

The only things "wrong" - so to speak - with the data file is that it's missing one column and it doesn't start with the column definition row.

Aside from those two things, it also needs CardImageURLs entries, which I'm attaching, which look like:

CardImageURLs:
mm15/1.jpg   http://magiccards.info/scans/en/mm2/1.jpg
mm15/2.jpg   http://magiccards.info/scans/en/mm2/2.jpg
mm15/3.jpg   http://magiccards.info/scans/en/mm2/3.jpg

In excel they were written like:

CardImageURLs:
=CONCATENATE("mm15/",G2,".jpg")   =CONCATENATE("http://magiccards.info/scans/en/mm2/",G2,".jpg")
=CONCATENATE("mm15/",G3,".jpg")   =CONCATENATE("http://magiccards.info/scans/en/mm2/",G3,".jpg")
=CONCATENATE("mm15/",G4,".jpg")   =CONCATENATE("http://magiccards.info/scans/en/mm2/",G4,".jpg")
Title: Re: Magic Plugin Update
Post by: Burst on June 14, 2015, 09:32:52 AM
what column is it missing?

and, I didn't think the images were supposed to be full urls, just the base file name (no path, no extension), basically, it's the same format I gave Bort for DTK.

If it's not sufficient I can adjust, what is needed?

Title: Re: Magic Plugin Update
Post by: Burst on June 14, 2015, 09:37:39 AM
The format I used is so it could be appended to the allcards.txt or allcards2.txt files  "as is"


Title: Re: Magic Plugin Update
Post by: Bort on June 14, 2015, 09:50:26 AM
thanks for the help guys. I fixed those issues and decided on the name mm2 since that is what magiccards.info uses. the autoupdate links should be working now. the high scans arent out yet so those dont look as good as they will. I havent done all the scripts yet, so some of the automation isnt working yet for mm2, like planeswalkers adding loyalty counters etc.

the dtk card images are also updated to be the high res scans with this update.

the autoupdate url for high is http://www.normalitycomics.com/magicplugin/high/updatelist.txt
Title: Re: Magic Plugin Update
Post by: Burst on June 14, 2015, 12:03:59 PM
it's easy for me to adjust the output.  I thought I was giving you what you needed without requiring more work on your part.

If that's not the case, what would be the ideal file for you?

There aren't new pictures for Tempest Remastered yet, but when there are, I can generate a file for that for you too as a test of my generation scripts
Title: Re: Magic Plugin Update
Post by: AuraDragon on June 14, 2015, 11:49:19 PM
(The apparent fact that Bort doesn't use automated generation pains me deeply)

The Scripts column, goes right before the Text column.

I guess the column definition row isn't necessary in this case since Bort combines all the set data files into one or two files.
Title: Re: Magic Plugin Update
Post by: AuraDragon on June 15, 2015, 03:26:49 PM
The FRF set is still using names for the CardImage column even though the CardImageURLs was updated for that set to use numbers.  Because of this, the FRF set refuses to display images.
Title: Re: Magic Plugin Update
Post by: CrazyChucky on June 15, 2015, 08:16:46 PM
Same thing for Commander 2014, looks like.
Title: Re: Magic Plugin Update
Post by: CrazyChucky on June 16, 2015, 11:46:31 AM
A friend of mine fixed the image references for Fate Reforged and Commander 2014 in allcards2.txt, if you replace yours with this version it should work for now.

http://www.normalitycomics.com/stuff/allcards2.txt

(Note: yes, this is on the same server as the plugin itself. I host it, but Bort maintains it, so I don't want to go mucking about with the official package myself. Not sure how versioning and updating plugins works, anyway.)
Title: Re: Magic Plugin Update
Post by: ruddiger08 on June 16, 2015, 10:40:35 PM
Hmmm...tried to update using the link from Chucky and got.

  "Error!: Unable to download a valid updatelist.txt

Something on my end?
Title: Re: Magic Plugin Update
Post by: AuraDragon on June 17, 2015, 12:09:22 AM
That's not an update list, it's just a link to a card data file.

Download the card data file, and save it in your Magic plugin's set folder and you should be off to the races.
Title: Re: Magic Plugin Update
Post by: ruddiger08 on June 17, 2015, 12:45:28 AM
Thank you for the help but using Mac and does not seem to work.    If someone is aware of another method I am all eyes and ears.
Title: Re: Magic Plugin Update
Post by: AuraDragon on June 17, 2015, 03:24:10 AM
Download with your internet browser, I mean.

I have never used a Mac but it can't be THAT different from Windows can it?
Title: Re: Magic Plugin Update
Post by: ruddiger08 on June 17, 2015, 07:54:15 AM
I will play around with it.  I was referring to downloading the gatherer and gatherer extractor being a .exe file and macs require .dmg to install new programs.  Thanks though

UPDATE***I got it thank you!
Title: Re: Magic Plugin Update
Post by: dragostea on June 22, 2015, 04:34:50 PM
Not trying to nitpick, but in the descriptions for the color of a particular card ....

a blue card (normally listed as "u" in the color column)
is listed as ("b" - the symbol normally reserved for black cards)

How can I help fix this?
Title: Re: Magic Plugin Update
Post by: CrazyChucky on June 24, 2015, 06:43:55 PM
Post about it here and/or message Bort directly, I suppose. He's the maintainer.
Title: Re: Magic Plugin Update
Post by: Bort on June 27, 2015, 03:33:19 PM
thanks for input guys. i think its all working good. any other screw ups?
Title: Re: Magic Plugin Update
Post by: sephural on June 28, 2015, 09:15:50 PM
Unfortunately, yes. The ktk booster adds frf cards to the pool. Thanks for the work on the plugin. Much appreciated.
Title: Re: Magic Plugin Update
Post by: sephural on July 06, 2015, 02:23:32 PM
"coat with venom" is misspelled "coat with venum" as well as "lightning berserker" is misspelled "lightning beserker" and "berserkers' onslaught" is misspelled "beserkers' onslaught"
Title: Re: Magic Plugin Update
Post by: pickleishopeless on July 07, 2015, 09:17:04 AM
silumgar monument has silumgar butcher's card data.
Title: Re: Magic Plugin Update
Post by: sephural on July 11, 2015, 05:11:00 PM
The update broke the card image downloads. None will download. all the text is in the plugin even for origins but card images all error on download no matter what set they are from.
Title: Re: Magic Plugin Update
Post by: AuraDragon on July 11, 2015, 05:42:23 PM
Yep, we're aware of my mistake, no need to rub it in.   :'(   It's going to be fixed in probably a few hours, once the host of NormalityComics gets my email.

To temporarily fix it, just change the 'CardImageURLs:' line in the updatelist.txt to 'CardURLFiles:', or don't, and we'll do it for you in a few hours lol.
Title: Re: Magic Plugin Update
Post by: sephural on July 11, 2015, 06:42:35 PM
Ok. Sorry about that. I had no intention of rubbing it in. I really appreciate the work put in to this plugin.
Title: Re: Magic Plugin Update
Post by: AuraDragon on July 11, 2015, 06:46:21 PM
No worries.  I was just joking about rubbing it in.  ;D  Send all your appreciation to Bort, he deserves it.
Title: Re: Magic Plugin Update
Post by: sephural on July 12, 2015, 11:34:44 PM
Dazzling Ramparts shows a cost of 1W but it is actually 4W.

Edit: Silumgar Sorcerer has a type of "Artifact" but it should be "Creature - Human Wizard"
Title: Re: Magic Plugin Update
Post by: InfernoCommander on July 13, 2015, 08:30:57 PM
I noticed some cards are showing up in incorrect formats. IE Ponder and Sensei's Diving Top are showing when sorted by Modern even though they're banned from the format.
Title: Re: Magic Plugin Update
Post by: AuraDragon on July 13, 2015, 08:57:12 PM
Lackey doesn't take in to account whether or not a card is banned.
Title: Re: Magic Plugin Update
Post by: dragostea on July 14, 2015, 03:02:57 PM
Dementia Altar shows up twice when "ignore doubles" is clicked.

once for mirage and once for conspiracy.

O_o
Title: Re: Magic Plugin Update
Post by: AuraDragon on July 14, 2015, 05:00:34 PM
Quote from: dragostea on July 14, 2015, 03:02:57 PMDementia Altar shows up twice when "ignore doubles" is clicked.

That's because one of the "Alter of Dementia" has a capital 'o' in 'of'.  xP 
Title: Re: Magic Plugin Update
Post by: dragostea on July 14, 2015, 10:23:54 PM
This is a political statement, I'm sure.
Title: Re: Magic Plugin Update
Post by: Bort on July 16, 2015, 12:27:42 AM
update should be out tomorrow...
thanks to those who helped
Title: Re: Magic Plugin Update
Post by: AuraDragon on July 16, 2015, 01:57:20 AM
Hey Bort!  Welcome back.  Here's a comprehensive run-down on what I changed:

Added Origins to the High and Medium carddata files.
- Scripts haven't been added
- Nor sounds
- Nor tokens
Added card images for High and Medium (including tokens), they are in setimages rather than cards.
Added Origins to the packs definition.
Switched End Step and Discard Step to proper order in plugininfo.

And that's it, all the carddata and cardimageurl additions are in new files.
Title: Re: Magic Plugin Update
Post by: CrazyChucky on July 16, 2015, 02:08:17 PM
Yay, it's Bort!

Hope you don't mind that I let Snoogy help out with Origins. Good to hear from you again. : )