LackeyCCG

LackeyCCG Forum => Bug Report Forum => Topic started by: Chris on August 24, 2013, 08:48:40 AM

Title: Skin settings remembered with plugin
Post by: Chris on August 24, 2013, 08:48:40 AM
Hi Trevor,

I know this isn't a bug but a feature. But since the skin-system changed to the new version that uses graphical interface elements the fact that skin settings are retained with each plugin isn't very useful anymore. It can even lead to pretty unexpected results.

Right now when you update an existing installation of Lackey to the latest version the new interface elements are installed, but when you use a non-standard skin file the text colors for that skin file are used, which can result in quite jarring colors ad even to unreadable text on the new button graphics.
Because as of yet the graphical interface elements are not linked to a specific skin (.txt) file, the interface elements do not change with the selected skin. Only the text color and other non-graphical elements of the skin do. I do not know if you intend to link specific graphical elements to the text skin files in the future, but for now it may be more user friendly to always load the default skin text file on a plugin change.


I just noticed something else: On a fresh install of Lackey the interface looks good, but after installing a new plugin and changing the plugin file the colors also go wonky. Suddenly a lot of stuff turns blue. I don't know where Lackey takes these colors from, but they are not the default skin. If you manualy change the skin back to default the colors are alright again.

The images below show what I mean.
Fresh installation of Lackey
(http://www.chrisvos.com/meuk/lackey/Lackey_FreshInstall.png)

Directly after plugin change
(http://www.chrisvos.com/meuk/lackey/Lackey_PluginLoaded.png)


Kind regards,
Chris
Title: Re: Skin settings remembered with plugin
Post by: Trevor on August 24, 2013, 12:03:41 PM
I am not happy with the current disconnect between the skin color elements and the GUI image components. When I finish doing more important things, I'm going to make things work in a more logical and usable way.

I think the bug you stumbled on is setting things to the skin default colors, which are not colors stored in any txt file but just some random values I chose to hard code in that should only ever be read if no appropriate skin file is found. I'll take a look when I get a chance.