LackeyCCG

LackeyCCG Forum => Plugins & Plugin Creation Forum => Topic started by: Thelovebus on April 27, 2011, 01:48:10 AM

Title: Unable to download pics
Post by: Thelovebus on April 27, 2011, 01:48:10 AM
I have had this plugin working for sometime now when I try to add some cards to it No one can download the new images so i laoded a new lackey install downloaded the plugin fine but now can't download any images. Can you take a look and see if I am doing something wrong?
http://highlander2ndedlackey.net/Highlander2e/updatelist.txt

Title: Re: Unable to download pics
Post by: Alastair on April 27, 2011, 02:51:21 AM
Not certain but it might be the length of the image names or that they have spaces in them.
Title: Re: Unable to download pics
Post by: Picks-at-Flies on April 27, 2011, 06:04:00 AM
Length of name should no longer be a problem, but I seemed to think spaces in names were.
Title: Re: Unable to download pics
Post by: Thelovebus on April 27, 2011, 11:16:16 AM
Spaces were not a problem before. I have had this up and running being able to download every image. I have changed nothing. But according to wireshark you are right.
<p>The requested URL /Highlander2e/sets/setimages/038 was not found on this server.</p>\n it is not requesting the full name. When did thischange because like i said this used too work? now i have too change filenames for 2600 cards
Title: Re: Unable to download pics
Post by: Thelovebus on April 27, 2011, 11:21:09 AM
I think I see the difference. I did a capture before when it was woking. Here is an Example of how lackey used to request the file.
GET /Highlander2e/sets/setimages/119%20-%20Amanda%20-%20Extra%20Shot.jpg HTTP/1.1\r\n

And this is from a capture when it is not working.
Here is how it is doing it now
GET /Highlander2e/sets/setimages/001 - F - Upper Left Attack.jpg HTTP/1.1\r\n

I did do a test of  3 images and it does work without spaces.

Why was this changed?

Title: Re: Unable to download pics
Post by: Trevor on April 27, 2011, 01:51:23 PM
You shouldn't put spaces in URLs. There's no reason to, and it is a pain to deal with.
Title: Re: Unable to download pics
Post by: Handlin on April 27, 2011, 02:07:15 PM
Heres a nice batch file renamer if it helps with those 2600 cards :D

and its free too!!!

http://www.den4b.com/?x=products&product=renamer

GL
Title: Re: Unable to download pics
Post by: Thelovebus on April 27, 2011, 04:15:34 PM
So you just decided to change it?
Title: Re: Unable to download pics
Post by: Picks-at-Flies on April 27, 2011, 05:39:37 PM
Thelovebus - I can't say if Trevor deliberately changed it or not, but the fact is that leaving spaces in filenames on the web is very bad practice.  Just googling gave all sorts of reasons why they are awkward, but the relevant one is that every time code might call a filename it has to jump through hoops if it is to allow for spaces in a filename. Much better that you stick to convention rather than make Trevor do a disproportionate amount of work his end.
Title: Re: Unable to download pics
Post by: Thelovebus on April 27, 2011, 10:52:36 PM
thats fine I am in process of changing it but one update just hosed hours of work i put into this plugin I just would like an heads up if it is going to happen so I can prepare for it.